Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flang][OpenMP] Duplicate the utils needed by DoConcurrentConversion #88

Merged
merged 1 commit into from
May 16, 2024

Conversation

ergawy
Copy link

@ergawy ergawy commented May 16, 2024

This adds a temporary (but more localy workaround) for the linker issue resulted from linking with OpenMP/Utils.cpp. This duplicates the required functions until we find a proper CMake solution.

This adds a temporary (but more localy workaround) for the linker issue
resulted from linking with `OpenMP/Utils.cpp`. This duplicates the
required functions until we find a proper CMake solution.
Copy link

@skatrak skatrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll have to look later into creating some shared library for lowering+transform utils and remove duplicates.

@ergawy ergawy merged commit b24abaa into ROCm:amd-trunk-dev May 16, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants