Update env.rst syntax #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhuiYH
added
documentation
lpaoletti
reviewed
May 23, 2024
amd/hipcc/docs/env.rst
Outdated
| @@ -10,7 +10,7 @@ HIPCC environment variables | |||
|
|
|||
| The environment variable ``HIP_PLATFORM`` can be used to specify ``amd`` or ``nvidia`` depending on the available backend tool flows: | |||
There was a problem hiding this comment.
Should these items be code?
Is this sentence saying you can use AMD or NVIDIA hardware?
There was a problem hiding this comment.
Everywhere else on the page, those items are in code-tags. The syntax is wrong and needs to be fixed, either by having the code tags rendered correctly, or to remove that line completely.
corrected HIP_PLATFORM example
randyh62
approved these changes
May 23, 2024
lpaoletti
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.