Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flang][OpenMP] Use an enum for DoConcurrentConversionPass::mapTo #96

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

ergawy
Copy link

@ergawy ergawy commented May 27, 2024

Cleans-up do-concurrent conversion code a bit by moving from using
std::string for the mapTo option to using an enum. The same enum
is used across the code for flang-new, fir-opt, and bbc.

Copy link

@Meinersbur Meinersbur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Cleans-up do-concurrent conversion code a bit by moving from using
`std::string` for the `mapTo` option to using an `enum. The same `enum`
is used across the code for `flang-new`, `fir-opt`, and `bbc`.
@ergawy ergawy merged commit a400728 into ROCm:amd-trunk-dev Jun 4, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants