[MLIR][Flang][OpenMP] Remove unused global variables in offload target module #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominikAdamski
changed the title
skatrak
reviewed
Jun 5, 2024
There was a problem hiding this comment.
Thank you Dominik, this looks good. It seems like it should work for deleting globals only used inside of host functions with no target regions, since these functions are the ones removed by the function filtering pass (hence removing all uses). However, if a global is used in the host part of a function containing a target region then this pass won't delete it, because that host function will remain. Have you thought about this case?
| op->walk<WalkOrder::PreOrder>([&](fir::GlobalOp globalOp) { | ||
| bool symbolUnused = true; | ||
| SymbolTable::UseRange globalUses = *globalOp.getSymbolUses(op); | ||
| for (SymbolTable::SymbolUse use : globalUses) { |
There was a problem hiding this comment.
I think setting symbolUnused can be simplified by using llvm::any_of() instead of this loop.
DominikAdamski
force-pushed
the
omp_global_vars
branch
from
0fa4873
to
c79a5dc
Compare
dpalermo
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.