Merge pull request #56 from jichangjichang/master

fix bug in rcclReduce for prod op
ROCm · Nov 29, 2018 · 76cd53d · 76cd53d
2 parents cf6bbf3 + 2f72457
commit 76cd53d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/rcclScalarReduceKernels.h b/src/rcclScalarReduceKernels.h
@@ -42,7 +42,7 @@ __global__ void RcclKernelScalarReduce(RingNode_t* pcurr_track, const void* send
                 reinterpret_cast<DataType_t*>(pnext_track->src_buffer);
 
             if (Op == rcclSum) result = result + next_src_buff[index];
-            if (Op == rcclProd) result = result + next_src_buff[index];
+            if (Op == rcclProd) result = result * next_src_buff[index];
             if (Op == rcclMax)
                 result = result > next_src_buff[index] ? result
                                                        : next_src_buff[index];