rocSPARSE general functions (part III) #114
Conversation
| solve_policy, | ||
| temp_buffer)); | ||
|
|
||
| // 6. Perform triangular solve A' y = alpha * x. |
| This triangular solver is used to solve a linear system of the form | ||
|
|
||
| $$ | ||
| A'y = \alpha x, |
There was a problem hiding this comment.
Can we use op(A) rather than A' ? This is confusing.
There was a problem hiding this comment.
Hmm, this is also present in many other examples from rocSPARSE and in one example from rocBLAS, I propose to update either all of them or none, to keep the notation consistent. If this notation is preferred, I can create an internal issue and we'll upstream the fix when it's done (so in another PR)
There was a problem hiding this comment.
I would suggest to update all of them. Feel free to do it in a separate PR, but A' is not a good notation.
There was a problem hiding this comment.
Noted 👍🏼. I'll open a separate PR when this is done
Beanavil
force-pushed
the
sparse-general-functions-3
branch
from
7ce7864
to
82570be
Compare
|
@YvanMokwinski I think this is ready to merge, as the changes requested for changing the notation |
This pull request contains the third (and last) part of the fourth batch of rocSPARSE examples. This group of examples corresponds to the ones that showcase general functions' (not corresponding to a particular matrix format) use. The original PR has been divided into several of them because the total amount of examples to upstream for this batch is too big for only one PR. This third part includes four examples:
csritsvspitsvgtsvgpsv