-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop Stream 2024-05-06 implementation #115
Develop Stream 2024-05-06 implementation #115
Conversation
Common/HipPlatform.cmake
Outdated
|
||
function(select_gpu_language) | ||
if (DEFINED CACHE{GPU_RUNTIME} AND NOT "${ROCM_EXAMPLES_GPU_RUNTIME_DISABLE_WARN}") | ||
message(DEPRECATION "GPU_RUNTIME is deprecated, please use ROCM_EXAMPLES_GPU_LANGUAGE to set" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this change, we see ~300 cmake warnings. I think we should clean up the remaining examples before finally merging this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because there are still two phases yet to be implemented until the feature is complete (that is, until the examples can be used with the NVIDIA platform of CMake's hip language support). We can drop this commit for now and push the feature when it is fully implemented if that's better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can keep the PR open until subsequent parts are done. I just think it would be a bad user experience to anyone trying to build the examples and then seeing all these warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the second and third phases of this feature will take quite a long time. I just dropped this commit to not drag this PR further, and we'll upstream it when finished.
c337f46
to
494ce11
Compare
494ce11
to
12e8fad
Compare
@dgaliffiAMD regarding this question, there was a commit implementing part of that issue, as we internally started to work on that. But we designed internally 3 phases to implement the whole feature, and only the first of them is done as of now. |
12e8fad
to
8a73fca
Compare
This PR contains the commits that implement new examples/features. The changes introduced in this PR can be summarized into: