Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cmake-format to CI #121

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Add cmake-format to CI #121

merged 3 commits into from
Jun 5, 2024

Conversation

dgaliffiAMD
Copy link
Collaborator

No description provided.

@dgaliffiAMD dgaliffiAMD marked this pull request as ready for review June 3, 2024 20:54
@dgaliffiAMD dgaliffiAMD marked this pull request as draft June 3, 2024 20:54
@dgaliffiAMD dgaliffiAMD force-pushed the amd/dgaliffi/cmake-format branch 2 times, most recently from 58c0651 to be2c1a4 Compare June 3, 2024 23:47
@dgaliffiAMD dgaliffiAMD marked this pull request as ready for review June 4, 2024 00:05
@Naraenda
Copy link
Member

Naraenda commented Jun 4, 2024

cmake-format seems to be no longer maintained: last update 3 years ago. Can something like gersemi be a better alternative?

@dgaliffiAMD
Copy link
Collaborator Author

cmake-format seems to be no longer maintained: last update 3 years ago. Can something like gersemi be a better alternative?

Thanks! I'm not familiar with gersemi, outside of Norse mythology. The usage looks similar to cmake-format, so it should be an easy patch. I'll look into it. :)

@dgaliffiAMD dgaliffiAMD force-pushed the amd/dgaliffi/cmake-format branch 3 times, most recently from e3a7671 to 422f9b0 Compare June 4, 2024 20:46
@dgaliffiAMD
Add cmake file formatting to CI
42bcf51 
Using gersemi - https://github.com/BlankSpruce/gersemi

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
@dgaliffiAMD
Fix failures in CMake linting
649812f 
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
@dgaliffiAMD
Fixed tabbing in linting.yml
05a5bfb 
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Naraenda
Naraenda approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@Naraenda Naraenda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dgaliffiAMD
Copy link
Collaborator Author

Thanks for the tip, @Naraenda . Gersemi was nice to work with. Similar to cmake-format but with some nice quality-of-life improvements, like accepting the directory as a source.

@dgaliffiAMD dgaliffiAMD merged commit b725fd7 into develop Jun 5, 2024
3 checks passed
@dgaliffiAMD dgaliffiAMD deleted the amd/dgaliffi/cmake-format branch June 5, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naraenda Naraenda Naraenda approved these changes

@Beanavil Beanavil Beanavil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgaliffiAMD @Naraenda @Beanavil