Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduction tutorial #128

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Reduction tutorial #128

merged 1 commit into from
Aug 26, 2024

Conversation

neon60
Copy link
Contributor

@neon60 neon60 commented Jun 19, 2024

This example code is needed for one of our tutorial on HIP:
ROCm/HIP#3513

@neon60 neon60 requested review from a team and dgaliffiAMD as code owners June 19, 2024 12:45
dgaliffiAMD
dgaliffiAMD requested changes Jul 3, 2024
View reviewed changes
Tutorials/Reduction/README.md Outdated Show resolved Hide resolved
@matyas-streamhpc matyas-streamhpc self-requested a review July 29, 2024 13:13
@matyas-streamhpc matyas-streamhpc force-pushed the reduction-tutorial branch 2 times, most recently from 941288f to cb9980b Compare August 1, 2024 14:05
@dgaliffiAMD dgaliffiAMD self-requested a review August 1, 2024 14:31
@dgaliffiAMD dgaliffiAMD self-requested a review August 1, 2024 17:24
dgaliffiAMD
dgaliffiAMD reviewed Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@dgaliffiAMD dgaliffiAMD left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter is still catching a couple of formatting errors in the CMakeFiles.
You can use gersemi to fix these issues: gersemi -i $(find . -type f | egrep 'CMakeLists.txt|\.cmake$')

Tutorials/CMakeLists.txt Show resolved Hide resolved
Tutorials/Reduction/test/CMakeLists.txt Outdated Show resolved Hide resolved
Tutorials/Reduction/example/CMakeLists.txt Outdated Show resolved Hide resolved
Tutorials/Reduction/benchmark/CMakeLists.txt Outdated Show resolved Hide resolved
@dgaliffiAMD dgaliffiAMD self-requested a review August 1, 2024 18:20
@matyas-streamhpc matyas-streamhpc force-pushed the reduction-tutorial branch 3 times, most recently from 4d9fbe1 to ea56258 Compare August 16, 2024 12:27
@dgaliffiAMD dgaliffiAMD merged commit b1b2122 into ROCm:develop Aug 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randyh62 randyh62 randyh62 approved these changes

@matyas-streamhpc matyas-streamhpc Awaiting requested review from matyas-streamhpc

@dgaliffiAMD dgaliffiAMD Awaiting requested review from dgaliffiAMD dgaliffiAMD is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@neon60 @randyh62 @matyas-streamhpc @dgaliffiAMD @MathiasMagnus