Fix CMake Failure Within Libraries/ #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Project languages is not set before "find_package" is called. This leads to a configuration failure when running `cmake` within the `Libraries/` folder. Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Beanavil
reviewed
Jun 21, 2024
There was a problem hiding this comment.
I think these should also be fixed:
Libraries/rocBLAS/level_1/CMakesLists.txtLibraries/rocBLAS/level_2/CMakesLists.txtLibraries/rocBLAS/level_3/CMakesLists.txtLibraries/rocSOLVER/CMakesLists.txtLibraries/rocSPARSE/level_2/CMakesLists.txtLibraries/rocSPARSE/level_3CMakesLists.txt
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Thanks. I've updated these files too. |
Beanavil
approved these changes
Jun 21, 2024
dgaliffiAMD
added a commit
that referenced
this pull request
Jun 21, 2024
* Fix CMake Failure Within Libraries/ Project languages is not set before "find_package" is called. This leads to a configuration failure when running `cmake` within the `Libraries/` folder. * Update README.md * Update project languages in additional CMakelists Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project languages is not set before "find_package" is called. This leads to a configuration failure when running
cmakewithin theLibraries/folder.