-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip texture management example on MI300 and above #130
Conversation
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Update CMakeList to still this example on gfx94*. Signed-off-by: David Galiffi <David.Galiffi@amd.com>
if(GPU_RUNTIME STREQUAL "CUDA") | ||
list(APPEND include_dirs "${ROCM_ROOT}/include") | ||
endif() | ||
if(NOT CMAKE_HIP_ARCHITECTURES MATCHES "gfx94*") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't add the folder on HIP-Basic/CMakeLists.txt
this change does not seem necessary IINM. I would suggest either keeping this and removing the skipping code on HIP-Basic/CMakeLists.txt
or vice-versa.
FYI: in our internal PR for fixing the examples for ROCm 6.1 we also solved this issue by doing + #if !defined(__HIP_NO_IMAGE_SUPPORT) || !__HIP_NO_IMAGE_SUPPORT
+ // Read the value from the texture, if supported.
unsigned char val = tex2D<unsigned char>(tex_obj, u, v);
+ #else
+ // Prevent compile errors on HIP architectures that do not support
+ // texture instructions.
+ (void)u;
+ (void)v;
+ (void)tex_obj;
+ unsigned char val = 0;
+ #endif within the texture management example, so it can still be compiled for the gfx94* archs. |
Co-authored-by: Beatriz Navidad Vilches <61422851+Beanavil@users.noreply.github.com>
Sorry for the late reply. I'm just getting back from vacation. |
@dgaliffiAMD yes, just opened the PR now (#138 ) :) |
Closing, as this will be addressed in PR#138. |
To resolve build failure when building the entire example suite on an MI300.