Add "Tutorials" directory to SOURCE_DIRS in build_packages.sh #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgaliffiAMD
reviewed
Aug 27, 2024
Scripts/Packaging/build_packages.sh
Outdated
| @@ -307,9 +299,6 @@ pushd "$GIT_TOP_LEVEL" || exit | |||
| # Print input variables | |||
| print_input_variables | |||
|
|
|||
| # Build the project, including tests | |||
| build_project | |||
There was a problem hiding this comment.
Isn't this what you are copying when you build the test packages?
There was a problem hiding this comment.
Yes @dgaliffiAMD, you are right—the build_project function produces the CTestTestfile.cmake files, which are then copied when building the test packages, I will revert the change
Mustaballer
force-pushed
the
add-tutorial-directory
branch
from
6eb559b
to
a8f627e
Compare
dgaliffiAMD
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the "Tutorials" directory to the
SOURCE_DIRSarray in thebuild_packages.shscript. This ensures that the content in the "Tutorials" directory is included during the package build process.Attached is the content of the source package file including the new Tutorial source files:
source-with-tutorial-deb-pkg-contents.txt