Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update divide_ceil struct in reduction tutorial #162

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Update divide_ceil struct in reduction tutorial #162

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1245c5
Update divide_cell
neon60 Sep 13, 2024
2965db4
Fix format
matyas-streamhpc Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 5 additions & 27 deletions Tutorials/reduction/include/tmp_utils.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,41 +142,19 @@ struct multiply
return I * J;
}
};
// Based on https://stackoverflow.com/a/63436491/1476661 by @jan-schultke

template<int J>
struct divide_ceil
{
template<int I>
FUNC_QUALIFIER constexpr int operator()()
{
using Dividend = decltype(I);
using Divisor = decltype(J);
static constexpr auto x = I;
static constexpr auto y = J;
if constexpr(std::is_unsigned_v<Dividend> && std::is_unsigned_v<Divisor>)
{
// quotient is always positive
return x / y + (x % y != 0); // uint / uint
}
else if constexpr(std::is_signed_v<Dividend> && std::is_unsigned_v<Divisor>)
{
auto sy = static_cast<std::make_signed_t<Divisor>>(y);
bool quotientPositive = x >= 0;
return x / sy + (x % sy != 0 && quotientPositive); // int / uint
}
else if constexpr(std::is_unsigned_v<Dividend> && std::is_signed_v<Divisor>)
{
auto sx = static_cast<std::make_signed_t<Dividend>>(x);
bool quotientPositive = y >= 0;
return sx / y + (sx % y != 0 && quotientPositive); // uint / int
}
else
{
bool quotientPositive = (y >= 0) == (x >= 0);
return x / y + (x % y != 0 && quotientPositive); // int / int
}
static_assert(std::is_signed_v<decltype(I)> && std::is_signed_v<decltype(J)>,
"Invalid type.");
return (I + J - 1) / J;
}
};

template<typename Pred, typename TruePath, typename FalsePath>
struct select
{
Expand Down
Loading