Prevent forward events from overtaking cancel events. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add compile time option to stop sending of events from a PE if a cancel event is being held for its corresponding forward event from being sent. cmake option: PRIORITIZE_CANCEL_EVENTS default value: OFF This is still no fool-proof because on the receive side, MPI_Testsome may succeed for events sent later. However, for small messages that ROSS usually sends (<1 KB), this is unlikely. Change-Id: I2800a2a6d3537317c6182047ff0beeb3ba238037
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
=======================================
Coverage 75.24% 75.24%
=======================================
Files 32 32
Lines 4039 4039
Branches 752 752
=======================================
Hits 3039 3039
Misses 973 973
Partials 27 27
Continue to review full report at Codecov.
|
|
Thoughts? @carothersc |
|
Can you explain the process of your project, and what you need accomplished?
… On Aug 14, 2017, at 3:02 PM, Nikhil Jain ***@***.***> wrote:
Thoughts? @carothersc <https://github.com/carothersc>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <https://github.com/carothersc/ROSS/pull/123#issuecomment-322279162>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AcyV1cfGfuOHCWJs_HbyJPVn14rPUpyjks5sYJmrgaJpZM4OnQ6u>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compile time option to stop sending of events from a PE if a cancel event is
being held for its corresponding forward event from being sent.
cmake option: PRIORITIZE_CANCEL_EVENTS
default value: OFF
This is still no fool-proof because on the receive side, MPI_Testsome may
succeed for events sent later. However, for small messages that ROSS usually
sends (<1 KB), this is unlikely.
Change-Id: I2800a2a6d3537317c6182047ff0beeb3ba238037
@mmubarak - you may be interested in this.
If this merge represents a feature addition to ROSS, the following items must be completed before the branch will be merged:
Include a link to your blog post in the Pull Request.