Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path to executable #119

Merged
merged 1 commit into from
Sep 7, 2024
Merged

Fix path to executable #119

merged 1 commit into from
Sep 7, 2024

Conversation

kriths
Copy link
Contributor

@kriths kriths commented Aug 30, 2024

Fix the path declaration for bin in package.json. This should fix running directly using npx.

Tried running this and it worked again: npx https://github.com/kriths/license-checker-rseidelsohn --json --production

Fixes: #118

@denydias
Copy link

denydias commented Aug 30, 2024

#119 works only when installed as package. For the ones installing it system wide (i.e. as stated in README intro as npm install -g license-checker-rseidelsohn), the executable once in /usr/bin/license-checker-rseidelsohn is not present anymore.

@denydias
Copy link

For the ones looking for a quick fix:

# ln -s ../lib/node_modules/license-checker-rseidelsohn/bin/license-checker-rseidelsohn.js /usr/bin/license-checker-rseidelsohn
$ license-checker-rseidelsohn --version
4.4.1

@firecow
Copy link

firecow commented Sep 3, 2024

I approve this message, all our CI/CD pipelines just exploded 👍

@Xaseron
Copy link

Xaseron commented Sep 3, 2024

i've added this to my pipelines:

export PATH=$PATH:$(dirname $(find / -name license-checker-rseidelsohn.js -type f -print -quit 2>/dev/null))

@aksyuma
Copy link

aksyuma commented Sep 4, 2024

will this fix be merged soon and documentation updated?

@firecow
Copy link

firecow commented Sep 7, 2024

@RSeidelsohn Can you give this some love, so our CI/CD pipelines can become green once again 🤣

@RSeidelsohn
Copy link
Owner

@RSeidelsohn Can you give this some love, so our CI/CD pipelines can become green once again 🤣

Hi @firecow , thanks for the nice ping - I just saw this and of course I merge it right now. Have a great weekend and please excuse me having brought you that error!

Copy link
Owner

@RSeidelsohn RSeidelsohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, I am very sorry for that. Thanks a lot for your PR!

@RSeidelsohn RSeidelsohn merged commit 00ad110 into RSeidelsohn:master Sep 7, 2024
2 checks passed
@firecow
Copy link

firecow commented Sep 9, 2024

@RSeidelsohn No problem at all, we can live with a couple of broken Renovate MR's 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executable binary doesn't work anymore