Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: get tests running in CI #124

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dbjorge
Copy link

@dbjorge dbjorge commented Oct 25, 2024

While I was looking at making a different contribution, I noticed that the repo's tests weren't in a running state. It looks like the tests were written prior to the project converting to "type": "module", but the tests were never updated to work with that. This PR:

  • Replaces jenkins-mocha and nyc with mocha and c8 to re-enable debugging and code coverage
  • Updates the tests to use ESM syntax instead of CJS syntax
  • Updates how packages-test.js was using child_process.spawn to fix how it was trying to read stdout
  • Updates test.ts cases that pin to the actual dependencies of the repo to account for the dependency updates
  • Adds a GitHub Actions configuration to run lint + format + test checks on PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant