Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted checks on clear cb cleanup function to allow for client obje… #336

Merged
merged 7 commits into from
Oct 29, 2024

Conversation

djs0109
Copy link
Contributor

@djs0109 djs0109 commented Oct 22, 2024

closes #331

@djs0109 djs0109 requested a review from sbanoeon October 22, 2024 13:45

def test_clear_quantumleap(self):
# TODO
pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add quantumleap test?

Copy link
Contributor

@sbanoeon sbanoeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please include changes in CHANGELOG.md.

@djs0109
Copy link
Contributor Author

djs0109 commented Oct 29, 2024

@sbanoeon could you check again after the tests runing through?

@djs0109 djs0109 merged commit ee798b4 into master Oct 29, 2024
1 check passed
@djs0109 djs0109 deleted the 331-Clean-up-function-of-CBC branch October 29, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up function of CBC
3 participants