Skip to content
This repository has been archived by the owner on Oct 31, 2018. It is now read-only.

Switch to jekyll #160

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Switch to jekyll #160

wants to merge 26 commits into from

Conversation

rrrodrigo
Copy link
Contributor

No description provided.

@rrrodrigo
replace Middleman with Jekyll: step 1 (rendering index.html without s…
7c15ef8 
…tyling)
@rrrodrigo
set up styling using jekyll-assets
7b03c6e
@rrrodrigo
set up fonts using jekyll-assets
584587e
@rrrodrigo
set up images using jekyll-assets
1fee552
@rrrodrigo
redefine responsive_image_tag helper as custom Liquid tag
8c6d0e9
@rrrodrigo
use Jekyll's site attributes in the layout template directly (DRYing)
d26ee0a
@rrrodrigo
set up JS using jekyll-assets
f9445fb
@rrrodrigo
render what-we-did using Liquid tags (in progress)
50c201c
@rrrodrigo
complete conversion of what-we-did page to Liquid
5013d25
@rrrodrigo
Highlight current page in navigation
08e1065
@rrrodrigo
convert who-we-are page to Liquid
0c1f6fd 
also:
 * restore header font in template
 * fix the dot-afer-link problem in the footer
@rrrodrigo
convert brand guidelines page to Slim
883c1dd
@rrrodrigo
convert contact-us page to Liquid
cb734d8
@rrrodrigo
replace   with proper Slim formatting in the footer
0afab20
@rrrodrigo
fix E-mail display at main office
271fd66
@rrrodrigo
change the path of contact page
d6e71b9
@rrrodrigo
add contact-thanks page
169b864 
DRY the source by using default layout specified in config file
@rrrodrigo
DRY the source by including header and footer in layout template
9e890de
@rrrodrigo
remove the line between header and content on index page
bd9c893 
also: improve consistency by using Slim also for index page
@rrrodrigo
remove Middleman leftovers
97438be
@rrrodrigo
add 404 page, converted to Liquid
ae74e9f
@rrrodrigo
add favicons
7a384b7
@rrrodrigo
remove Middleman source dir
0919456
@rrrodrigo
Fix font loading over https
990c1dd
@rrrodrigo
add Intercom
85fa303
@rrrodrigo
rearange assets placement to make it more consistent
0ae154a
@rrrodrigo
Copy link
Contributor Author

rrrodrigo commented Oct 18, 2016 •
edited
Loading

This PR proves than our homepage can be converted from Middleman to Jekyll. However, there are 3 problems with the resulting code:

  1. External JS and CSS libraries are placed in source form in _assets/css/vendor/ and _assets/javas/vendor/, as current version of jekyll-assets no longer supports easy integration with http://rails-assets.org. As a consequence, we'd need to maintain our copies of these libraries and keep them up-to-date - no easy integration with gems as before.
  2. Our pages' sources are using a mix of Slim and Liquid, which is weird to read and write, due to Liquid requiring closing tags and Slim using indentation instead. This problem can be fixed relatively easy, by removing Slim from the toolkit and switching to plain HTML with Liquid tags.
  3. Images and other assets are copied over to output only when referred to with Liquid helpers in the source. Anytime we are using custom helpers/filters to DRY the source, they need to be listed as comment to ensure they appear in the final output. See an example here.

In the view of the above, I think switching to Jekyll would not be a worthwile improvement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rrrodrigo