Do not return true in service

RailsEventStore · Sep 17, 2024 · fddc415 · fddc415
1 parent c999e22
commit fddc415
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/rails_application/app/services/client/orders/submit_service.rb b/rails_application/app/services/client/orders/submit_service.rb
@@ -23,10 +23,9 @@ def call
           end
           .call
 
-          if unavailable_products.any?
-            raise OrderHasUnavailableProducts.new(unavailable_products)
-          end
-        true
+        if unavailable_products.any?
+          raise OrderHasUnavailableProducts.new(unavailable_products)
+        end
       end
 
       private