Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

210329 homepage login #367

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

210329 homepage login #367

wants to merge 3 commits into from

Conversation

sibsmc
Copy link
Collaborator

@sibsmc sibsmc commented Mar 31, 2021

No description provided.

@sibsmc sibsmc requested a review from cecastosic March 31, 2021 18:02
@sibsmc sibsmc added the frontend Issue for frontend team label Mar 31, 2021
@sibsmc
Copy link
Collaborator Author

sibsmc commented Mar 31, 2021

Basic prototype version, homepage shows sign up and log in links if there is no valid token.
Once user gets valid token via either path user is redirected to homepage with log out button.

@sibsmc
Copy link
Collaborator Author

sibsmc commented Apr 7, 2021

This pull requests meets the acceptance criteria for #13
A user can now sign up, log out, and then log back in again.

Work still outstanding:
It does not cover the nice-to-have from #13, i.e. when you have been registered you are not redirected to a profile page.
(nice to have) the user's profile can be opened and changed at a later stage i.e. the last screen has its own address e.g. /profile

The design created by Marci is not used for the welcome page so that needs to be updated as well. This change just handles the sign in, log in and log off.

marcidenmark
marcidenmark approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@marcidenmark marcidenmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side, it looks good. Thanks Siobhan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcidenmark marcidenmark marcidenmark approved these changes

@cecastosic cecastosic Awaiting requested review from cecastosic

@diwanow diwanow Awaiting requested review from diwanow

Assignees
No one assigned
Labels
frontend Issue for frontend team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sibsmc @marcidenmark