-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge completed tasks from roadmap 0.3.0 into master #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applied navigation bar padding to avoid bottom sheet collision.
Updated all previous dependencies. Minor compose ui corrections.
…tom-bar' into feature/handle-mulitple-bottom-sheets-home-screen # Conflicts: # app/src/main/java/com/developersbreach/composeactors/ui/screens/home/HomeBottomBar.kt # app/src/main/java/com/developersbreach/composeactors/ui/screens/home/HomeScreen.kt
Favorites now contain actors and movies tabs in separate screen.
…screens. Home screen has new tab section for upcoming feature TV Shows. Fixed issues in app navigation post modal sheet removal changes.
Upgrade to compose 1.4.1, updated android gradle plugin
…-screen # Conflicts: # app/src/main/java/com/developersbreach/composeactors/ui/screens/favorites/tabs/FavoriteMoviesTabContent.kt # app/src/main/java/com/developersbreach/composeactors/ui/screens/home/HomeScreenContent.kt # app/src/main/java/com/developersbreach/composeactors/ui/screens/home/HomeScreenUI.kt # app/src/main/java/com/developersbreach/composeactors/ui/screens/home/tabs/MoviesTabContent.kt
Update modal sheet changes with respect to api changes in compose 1.4.1 Fixed failing UI test
…ttom-sheets-home-screen Update navigation, rework modal sheets usages, rework favorites screen feature
…favorite-option Merge all navigation, bottom sheet, new feature changes into v0.3.0
…i-change Improved favorites movie ui improvements
…ils_screen # Conflicts: # app/src/main/java/com/developersbreach/composeactors/ui/screens/movieDetail/MovieDetailsContent.kt # app/src/main/java/com/developersbreach/composeactors/ui/screens/movieDetail/composables/GetSimilarOrRecommendedMovies.kt
…et_on_movie_details_screen Show movie detail sheet for recommended and similar movies in Movie details screen
…reen_for_actors Implemented favorite screen for Actors
Made design improvements to home, favorites screen pager
…-favorites-screen-ui Made design improvements to favorites actors screen and home screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task related to roadmap v0.3.0