Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darkmode update #1432

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

SSrushti-s
Copy link

Fixes Issue🛠️

Closes #1431

Description👨‍💻

I have changed the dark mode icon and added a hover effect to increase readability by increasing the brightness around it.

Type of Change📄

  • Style (non-breaking change which improves website style or formatting)
  • Responsiveness (non-breaking change which improves UI/UX on different screen sizes)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

Screenshot 2024-12-29 154050

Copy link

netlify bot commented Dec 29, 2024

Deploy Preview for beautiify ready!

Name Link
🔨 Latest commit fd48174
🔍 Latest deploy log https://app.netlify.com/sites/beautiify/deploys/6774f303e219f40009791fd4
😎 Deploy Preview https://deploy-preview-1432--beautiify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SSrushti-s, Welcome to the project Beautiify! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@Rakesh9100
Copy link
Owner

Just a single icon, include two icons for light and dark mode such as sun and moon @SSrushti-s

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Dec 29, 2024
@SSrushti-s
Copy link
Author

are these both icon fine ?
Screenshot 2024-12-29 231324
Screenshot 2024-12-29 231239

@Rakesh9100
Copy link
Owner

No, the first icon that you implemented was good, so accordingly you can choose other similar icon @SSrushti-s

@SSrushti-s
Copy link
Author

I did search the sun and moon pair which is similar to the icon but I could not find which could match the gradient hence I thought of choosing this both. So can you tell if these both are fine? @Rakesh9100
Screenshot 2024-12-29 231324
Screenshot 2024-12-29 231239

@Rakesh9100
Copy link
Owner

No, these icons don't go well with the website theme and seems blurry, can you search for some more, I am sure you will find it @SSrushti-s

@SSrushti-s
Copy link
Author

Then can I try using this and this?
Screenshot 2025-01-01 082127
Screenshot 2025-01-01 082109

@Rakesh9100
Copy link
Owner

Looks good, make the commits, and will check the deploy preview @SSrushti-s

@SSrushti-s
Copy link
Author

@Rakesh9100 I have made the changes kindly check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question 🤔 Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Style] Adding a hover effect on Dark mode icon
2 participants