-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darkmode update #1432
base: main
Are you sure you want to change the base?
Darkmode update #1432
Conversation
✅ Deploy Preview for beautiify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @SSrushti-s, Welcome to the project Beautiify! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨
Just a single icon, include two icons for light and dark mode such as sun and moon @SSrushti-s |
No, the first icon that you implemented was good, so accordingly you can choose other similar icon @SSrushti-s |
I did search the sun and moon pair which is similar to the icon but I could not find which could match the gradient hence I thought of choosing this both. So can you tell if these both are fine? @Rakesh9100 |
No, these icons don't go well with the website theme and seems blurry, can you search for some more, I am sure you will find it @SSrushti-s |
Looks good, make the commits, and will check the deploy preview @SSrushti-s |
@Rakesh9100 I have made the changes kindly check. |
Fixes Issue🛠️
Closes #1431
Description👨💻
I have changed the dark mode icon and added a hover effect to increase readability by increasing the brightness around it.
Type of Change📄
Checklist✅
Screenshots/GIF📷