Update OpenXR-SDK to 1.0.29 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasmusgo
commented
Sep 12, 2023
Ralith
reviewed
Sep 13, 2023
rasmusgo
commented
Sep 13, 2023
rasmusgo
commented
Sep 13, 2023
The problem with XR_HTC_passthrough was that we were generating code for XrCompositionLayerPassthroughHTC that didn't compile. This erroneous code was in the high level bindings so it turn out that we don't need to disable the whole extension if we just skip the high level bindings for XrCompositionLayerPassthroughHTC. This also removes the ugly blacklist for structs during parsing that was added to avoid the problematic code gen.
Ralith
reviewed
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what happened when I wanted to be able to use
XR_FB_haptic_pcmand went down the rabbit hole. There was a series of issues that I bumped into. Some are described in #134 but I chose to omit extensions with unlisted tags instead of allowing them (XR_EXTX_overlayetc).On a related note, this is the most hacky code I have written in a while. I am grateful for any hints on how to improve it.