Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support provisional extensions #156

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix: support provisional extensions #156

merged 1 commit into from
Apr 10, 2024

Conversation

galister
Copy link
Contributor

@galister galister commented Apr 10, 2024 •
edited
Loading

f1f4dab broke all provisional extensions:

  • XR_EXTX_overlay
  • XR_HTCX_vive_tracker_interaction
  • XR_MNDX_egl_enable
  • XR_MNDX_force_feedback_curl

The PR solves the issue by creating a new Tag if there is no matching Tag found for a provisional extension.

@galister galister changed the title fix: include EXTX,HTCX,MNDX extensions fix: support provisional extensions Apr 10, 2024
Ralith
Ralith approved these changes Apr 10, 2024
View reviewed changes
Copy link
Owner

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@Ralith Ralith merged commit f08f78b into Ralith:master Apr 10, 2024
6 checks passed
@galister galister deleted the legacy_naming branch April 10, 2024 05:23
@rasmusgo rasmusgo mentioned this pull request Apr 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galister @Ralith