Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to OpenXR 1.1.36 #158

Merged
merged 10 commits into from
Jul 26, 2024
Merged

Update to OpenXR 1.1.36 #158

merged 10 commits into from
Jul 26, 2024

Conversation

rasmusgo
Copy link
Contributor

This PR builds upon #157.

The biggest change in the generator is that <feature> tags are processed now. They are similar to <extension> but have a couple of important differences.

<interaction_profiles> were added in OpenXR 1.0.27 but we are still not using them. OpenXR 1.1.36 keeps building upon them with <extend> and <interaction_profile> tags inside <require> tags. I think we should consider adding support for them in another PR.

I used https://registry.khronos.org/OpenXR/specs/1.1/styleguide.html#schema and https://registry.khronos.org/vulkan/specs/1.3/registry.html to figure out the schema.

generator/src/main.rs Outdated Show resolved Hide resolved
@rasmusgo
Copy link
Contributor Author

rasmusgo commented Apr 24, 2024

  • Links to https://www.khronos.org/registry/OpenXR/specs/1.0/html/xrspec.html should be updated to 1.1.

@awtterpip
Copy link
Contributor

is there any ETA on this getting merged?

@Ralith
Copy link
Owner

Ralith commented May 14, 2024

It needs a rebase first, for one thing.

@rasmusgo
Copy link
Contributor Author

Rebased now. The most glaring problem is that the instance cannot be created if OpenXR 1.1 isn't supported by the loader, as we try to use the current API version when creating the instance:

api_version: CURRENT_API_VERSION,

@Ralith
Copy link
Owner

Ralith commented May 15, 2024

Would it make sense to take a version argument, deferring that problem to the application? That'd help us gracefully handle movement of extensions that we provide high-level wrappers for into core, too.

@rasmusgo
Copy link
Contributor Author

rasmusgo commented May 16, 2024

This runs with api version 1.0 now. I'm not sure what, if anything, is missing from the 1.1 spec. The only thing that disappeared when restricting the core commands to 1.0 was xrLocateSpaces from the high level bindings.

@rasmusgo rasmusgo requested a review from Ralith May 16, 2024 19:56
generator/src/main.rs Show resolved Hide resolved
generator/src/main.rs Outdated Show resolved Hide resolved
generator/src/main.rs Outdated Show resolved Hide resolved
generator/src/main.rs Outdated Show resolved Hide resolved
generator/src/main.rs Show resolved Hide resolved
@Ralith Ralith merged commit 47936d2 into Ralith:master Jul 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants