Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check validity of builder structs #166

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Check validity of builder structs #166

wants to merge 5 commits into from

Commits on Jul 26, 2024

  1. don't generate unused polymorphic builders 

    The removed builders aren't publicly exported and aren't used internally
    @Timbals
    Timbals committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    d05ff8f View commit details
    Browse the repository at this point in the history

  2. check the validity of builder structs 

    The only thing that isn't checked is that the `space` and `swapchain` handles come from the same session.
The spec only mentions this for the cube layer, but it is probably required for all layers.
    @Timbals
    Timbals committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    56dc179 View commit details
    Browse the repository at this point in the history

  3. replace builder structs with high-level enums/structs 

    Polymorphic structs get replaced with an enum. There's also a union for each enum that combines all the raw structs from the `sys` crate.
    @Timbals
    Timbals committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    9af2aba View commit details
    Browse the repository at this point in the history

  4. don't generate as_raw when containing mutable references

    @Timbals
    Timbals committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    87b5e12 View commit details
    Browse the repository at this point in the history

  5. mark create_swapchain as unsafe 

    Similar to `create_session`, the interaction with the graphics API means the runtime isn't required to check all requirements.
    @Timbals
    Timbals committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    75f2a60 View commit details
    Browse the repository at this point in the history