Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UB in Instance::supports_<prop>() #170

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Fix UB in Instance::supports_<prop>() #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions openxr/src/instance.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,9 @@ impl Instance {

#[inline]
pub fn supports_render_model_loading(&self, system: SystemId) -> Result<bool> {
if self.exts().fb_render_model.is_none() {
return Err(sys::Result::ERROR_EXTENSION_NOT_PRESENT);
}
unsafe {
let mut render_model = sys::SystemRenderModelPropertiesFB::out(ptr::null_mut());
let mut p = sys::SystemProperties::out(&mut render_model as *mut _ as _);
Expand All @@ -168,6 +171,9 @@ impl Instance {

#[inline]
pub fn supports_hand_tracking(&self, system: SystemId) -> Result<bool> {
if self.exts().ext_hand_interaction.is_none() {
return Err(sys::Result::ERROR_EXTENSION_NOT_PRESENT);
}
unsafe {
let mut hand = sys::SystemHandTrackingPropertiesEXT::out(ptr::null_mut());
let mut p = sys::SystemProperties::out(&mut hand as *mut _ as _);
Expand Down
Loading