added container documentation #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalphTro
requested changes
Dec 11, 2023
There was a problem hiding this comment.
Dear @dakbhavesh ,
Many thanks! How do you like the following slight improvement of the label description:
"This container hosts web services for generating the EPCIS Event Hash ID. It basically supports the following http endpoints: GET /health and POST /hash."
Contentwise, I would like to defer to @Echsecutor to confirm whether your suggestion meets the requirement he once had in mind.
Kind regards,
Ralph
|
Dear @RalphTro, Your suggestion for phrasing looks perfectly fine to me. I am looking forward to inputs from @Echsecutor |
|
Dear @RalphTro, As agreed, I have removed web service & container support. Please merge if the changes look good. FYI: @Echsecutor |
RalphTro
approved these changes
Jan 25, 2024
|
Many thanks, @dakbhavesh ! Happy to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @RalphTro & @Echsecutor ,
To address the issue #50 , I have added LABEL in the docker file as recommended by the below GitHub guidelines.
@RalphTro - your help will be needed with phrasing
@Echsecutor - your help will be needed to see if documentation is reflecting properly on the container registry
https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry