Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #5

Merged
merged 8 commits into from
Oct 28, 2024
Merged

Develop #5

merged 8 commits into from
Oct 28, 2024

Conversation

rak-randers
Copy link
Contributor

Serve vue from python flask backend/server

st-randers
st-randers approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@st-randers st-randers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated dev docker port and the command to run vite dev server

rak-randers
rak-randers commented Oct 28, 2024
View reviewed changes
Dockerfile Outdated
@@ -13,7 +13,7 @@ ENV GROUP_NAME=app
ENV HOME=/app
ENV GROUP_ID=11000
ENV USER_ID=11001
ENV PORT=8080
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skal være 8080 når den deploys. Brug dockerfile.dev til dev ting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@st-randers

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modtaget, bare sært at frontend udstilles på port 8080 her, og 3000 ellers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run dev laver en server og vite config filen sætter porten til 3000.
Men når det bygges med dockerfile til deployment, så er python/flask serveren og vue filerne bliver serveret her: https://github.com/Randers-Kommune-Digitalisering/vue-python-template/blob/develop/flask/src/main.py#L31-L37

Så der er kun én port. Men i dev er der to servere og defor to porte. Vite serveren tjekker efter fil-ændringer for vue filer og flask serveren er sat til debug i docker-compose og tjekker efter fil-ændringer for flask/python.

Håber det giver lidt mening 😅

@st-randers st-randers merged commit 6432fdd into main Oct 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st-randers st-randers st-randers approved these changes

@nk-randers nk-randers Awaiting requested review from nk-randers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rak-randers @st-randers