Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced opencv with imagesize to get the actual image size #548

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

cansik
Copy link
Contributor

@cansik cansik commented Dec 30, 2023

As described in #530, this PR replaces the use of opencv with the imagesize package to increase performance.

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (226d8cc) 74.80% compared to head (b87f72c) 74.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
- Coverage   74.80%   74.79%   -0.01%     
==========================================
  Files          71       71              
  Lines        4695     4694       -1     
  Branches      731      731              
==========================================
- Hits         3512     3511       -1     
  Misses        986      986              
  Partials      197      197              
Flag Coverage Δ
unittests 74.79% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cansik
Copy link
Contributor Author

cansik commented Dec 30, 2023

Strange, I did not change anything for the one-stage detector...

Copy link
Owner

@RangiLyu RangiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RangiLyu RangiLyu merged commit be9b4a9 into RangiLyu:main Jan 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants