Merge pull request #337 from RasaHQ/model-server-param

fix typing issue with customModelServer
RasaHQ · Apr 5, 2023 · 37afd2c · 37afd2c
2 parents 0f3075c + 987e369
commit 37afd2c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/charts/rasa-x/Chart.yaml b/charts/rasa-x/Chart.yaml
@@ -1,7 +1,7 @@
 ---
 apiVersion: v2
 
-version: "4.5.17"
+version: "4.5.18"
 
 appVersion: "1.2.2"
 
@@ -41,7 +41,5 @@ dependencies:
 annotations:
   # See: https://artifacthub.io/docs/topics/annotations/helm/#supported-annotations
   artifacthub.io/changes: |
-    - kind: added
-      description: Added support for defining a custom model server
-    - kind: added
-      description: Provide support for disabling nginx-specific annotations on ingress and added finer granularity for annotations on the two open-source ingress objects
+    - kind: fixed
+      description: Fixed issue with variable typing for customModelServer
diff --git a/charts/rasa-x/templates/rasa-config-files-configmap.yaml b/charts/rasa-x/templates/rasa-config-files-configmap.yaml
@@ -14,7 +14,7 @@ data:
   rasa-endpoints: |
   {{- if not $.Values.rasa.disableEndpointsModelServer }}
     models:
-    {{- if $.Values.rasa.customModelServer }}
+    {{- if (default $.Values.rasa.customModelServer false) }}
       url: ${CUSTOM_MODEL_SERVER}
     {{- else }}
       url: ${RASA_MODEL_SERVER}

diff --git a/charts/rasa-x/values.yaml b/charts/rasa-x/values.yaml
@@ -197,7 +197,7 @@ rasa:
   cacheDatabase: "2"
   # to fully override the model server URL set customModelServer to true AND define
   # CUSTOM_MODEL_SERVER in the extraEnvs section
-  customModelServer: "false"
+  customModelServer: false
   # extraEnvs are environment variables which can be added to the Rasa deployment
   extraEnvs: []
     # examples for defining the CUSTOM_MODEL_SERVER environment variable when