Introduced protections against system command injection

[zcarroll4]

This change hardens all instances of Runtime#exec() to offer protection against attack.

Left unchecked, Runtime#exec() can execute any arbitrary system command. If an attacker can control part of the strings used to as program paths or arguments, they could execute arbitrary programs, install malware, and anything else they could do if they had a shell open on the application host.

Our change introduces a sandbox which protects the application:

+ import io.github.pixee.security.SystemCommand;
  ...
- Process p = Runtime.getRuntime().exec(command);
+ Process p = SystemCommand.runCommand(Runtime.getRuntime(), command);

The default restrictions applied are the following:

• Prevent command chaining. Many exploits work by injecting command separators and causing the shell to interpret a second, malicious command. The SystemCommand#runCommand() attempts to parse the given command, and throw a SecurityException if multiple commands are present.
• Prevent arguments targeting sensitive files. There is little reason for custom code to target sensitive system files like /etc/passwd, so the sandbox prevents arguments that point to these files that may be targets for exfiltration.

There are more options for sandboxing if you are interested in locking down system commands even more.

More reading

• https://cheatsheetseries.owasp.org/cheatsheets/OS_Command_Injection_Defense_Cheat_Sheet.html
• https://wiki.sei.cmu.edu/confluence/display/java/IDS07-J.+Sanitize+untrusted+data+passed+to+the+Runtime.exec%28%29+method

Powered by: pixeebot (codemod ID: pixee:java/harden-process-creation) ![]

[HChenX]

Prevent arguments targeting sensitive files. There is little reason for custom code to target sensitive system files like /etc/passwd, so the sandbox prevents arguments that point to these files that may be targets for exfiltration.
Because most of our shell commands require access to system sensitive directories, such as'/sys/class', using this method may block our access.

[HChenX]

"chmod 0777 " + getPackageCodePath()
+" ; chmod 0777 " + PrefsUtils.mPrefsFile
+" ; chown root:root " + PrefsUtils.mPrefsFile
And the commands we need to execute may contain the delimiter ';'