github actions CI maintainence #2669
Conversation
|
This should fail at the 'download stable regression results' step, complaining that it could not find the artifact, possibly specifying that the reason it couldn't find it is because it was upload with a previous version of the upload artifact action (see: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md#which-versions-of-the-artifacts-packages-are-compatible). That would be resolved by ignoring this failure and merging anyway, then letting the CI run on main. |
.github/workflows/CI.yml
Outdated
| @@ -215,23 +215,24 @@ jobs: | |||
| run: mkdir stable_regression_results | |||
|
|
|||
| # Retrieve Stable Results for reference | |||
| # Will need to use this -> https://github.com/dawidd6/action-download-artifact | |||
| - name : ChatGPT said this would work - Get most recent CI run ID | |||
There was a problem hiding this comment.
Haha forgot i had that in there, removing now
yes! thanks for the reminder. will do this now |
- increment miniconda setup to v3 from v2 - set macos build runner to use intel macs rather than m1, since we don't have binaries for m1 - switch download artifact step to use the official github one, which now allows grabbing artifacts from other runs Resolves ReactionMechanismGenerator#2611 See ReactionMechanismGenerator#2667 for more history asdf
JacksonBurns
force-pushed
the
fix/ci_downloadv4
branch
from
5b111c8
to
192daea
Compare
- copy the download logic from RMG-Py (ReactionMechanismGenerator/RMG-Py#2669) that updates the version of download-artifact - increment setup-miniconda
|
@rwest could you take a look at ReactionMechanismGenerator/RMG-database#652? It's the database half of this PR. Both should 'fail' in the same way. |
JacksonBurns
merged commit 9749453
into
ReactionMechanismGenerator:main
Resolves #2611
See #2667 for more history