Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev.ej/py313 #251

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Dev.ej/py313 #251

merged 2 commits into from
Nov 12, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Nov 12, 2024

PR Goal?

Support Python 3.13

Fixes?

Addresses compatibility problems between some of our dependencies and Python 3.13

  • audioop has been removed from Python 3.13 standard libraries, but pydub still requires it. The community has rallied to fix this, in the form of audioop-lts, which we only need for Python >= 3.13
  • lxml 4.9.4 doesn't support Python 3.13. I'm not sure why we were locking the version anyway, so I just made it >= instead of ==. It to work just fine. The several lxlm 5.x releases don't list any breaking changes.

Feedback sought?

sanity checking

Priority?

medium

Tests added?

yes, added Py 3.13 to matrix testing (and it passes)

How to test?

install on Python 3.13 and have fun

Confidence?

high

Version change?

maybe a patch bump so pip install readalongs will work for Python 3.13.

Related PRs

ReadAlongs/SoundSwallower#67

Copy link

semanticdiff-com bot commented Nov 12, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  .github/workflows/matrix-tests.yml Unsupported file format
  requirements.min.txt Unsupported file format
  setup.py  0% smaller

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.51%. Comparing base (92111e9) to head (ee10315).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
+ Coverage   87.34%   87.51%   +0.16%     
==========================================
  Files          21       21              
  Lines        1786     1786              
  Branches      323      323              
==========================================
+ Hits         1560     1563       +3     
+ Misses        188      185       -3     
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joanise joanise merged commit ee10315 into main Nov 12, 2024
16 checks passed
@joanise joanise deleted the dev.ej/py313 branch November 12, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants