Merge branch 'feat/missed-progress-updates' into feat/progress-update…

…s-services
Real-Dev-Squad · Dec 12, 2023 · a46d4d1 · a46d4d1
2 parents 847c72b + 6b3717d
commit a46d4d1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/.github/workflows/production.yaml b/.github/workflows/production.yaml
@@ -8,6 +8,7 @@ jobs:
     environment: production
     steps:
       - uses: actions/checkout@v2
+      - run: npm install
       - uses: cloudflare/wrangler-action@2.0.0
         with:
           apiToken: ${{secrets.CLOUDFLARE_API_TOKEN}}

diff --git a/.github/workflows/staging.yaml b/.github/workflows/staging.yaml
@@ -8,6 +8,7 @@ jobs:
     environment: staging
     steps:
       - uses: actions/checkout@v2
+      - run: npm install
       - uses: cloudflare/wrangler-action@2.0.0
         with:
           apiToken: ${{secrets.CLOUDFLARE_API_TOKEN}}

diff --git a/src/handlers/scheduledEventHandler.ts b/src/handlers/scheduledEventHandler.ts
@@ -53,8 +53,12 @@ export async function callDiscordNicknameBatchUpdate(env: env) {
 	}
 
 	const data: NicknameUpdateResponseType = await response.json();
-	if (data?.data.totalUsersStatus !== 0 && data?.data.successfulNicknameUpdates === 0) {
-		throw new Error("Error while trying to update users' discord nickname");
+	if (data?.data.unsuccessfulNicknameUpdates === 0) {
+		try {
+			await namespace.put('DISCORD_NICKNAME_UPDATED_TIME', Date.now().toString());
+		} catch (err) {
+			console.error('Error while trying to update the last nickname change timestamp');
+		}
 	}
 
 	try {