refactor: update timestamp only when no unsuccessful updates

Real-Dev-Squad · Dec 9, 2023 · a6a313e · a6a313e
1 parent 966c509
commit a6a313e
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/src/handlers/scheduledEventHandler.ts b/src/handlers/scheduledEventHandler.ts
@@ -50,17 +50,15 @@ export async function callDiscordNicknameBatchUpdate(env: env) {
 	}
 
 	const data: NicknameUpdateResponseType = await response.json();
-	if (data?.data.totalUsersStatus !== 0 && data?.data.successfulNicknameUpdates === 0) {
-		throw new Error("Error while trying to update users' discord nickname");
+	if (data?.data.unsuccessfulNicknameUpdates === 0) {
+		try {
+			await namespace.put('DISCORD_NICKNAME_UPDATED_TIME', Date.now().toString());
+		} catch (err) {
+			console.error('Error while trying to update the last nickname change timestamp');
+		}
 	}
 
 	console.log(data);
 
-	try {
-		await namespace.put('DISCORD_NICKNAME_UPDATED_TIME', Date.now().toString());
-	} catch (err) {
-		console.error('Error while trying to update the last nickname change timestamp');
-	}
-
 	return data;
 }