Feat: OOO Nickname Update Job #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RitikJaiswal75
suggested changes
Sep 29, 2023
I spoke with Ankush regarding this. I didn't know a design doc was required (the mandate came later). The design doc is still in progress. I've informed him that I'll provide once done. |
ankushdharkar
requested changes
Oct 13, 2023
| try { | ||
| token = await generateJwt(env); | ||
| } catch (err) { | ||
| console.log(`Error while generating JWT token: ${err}`); |
There was a problem hiding this comment.
In the log both console.log and console.error appears as a generic log. But I've changed it to console.error anyway now.
wrangler.toml
Outdated
| # binding = "MY_KV_NAMESPACE" | ||
| # id = "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx" | ||
| kv_namespaces = [ | ||
| { binding = "CRON_JOBS_TIMESTAMPS", id = "a5431887e6c94dc9b3e36c35a07081b9" } |
There was a problem hiding this comment.
These are public IDs to identify namespaces bound to a single account.
| throw new Error("Error while trying to update users' discord nickname"); | ||
| } | ||
|
|
||
| console.log(data); |
| async scheduled(req: ScheduledController, env: env, ctx: ExecutionContext) { | ||
| switch (req.cron) { | ||
| case EVERY_4_HOURS: | ||
| ctx.waitUntil(ping(env)); |
There was a problem hiding this comment.
How does this notify us when backend is down?
ankushdharkar
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat: 1119 Update User Discord Nickname During OOO
Closes: Real-Dev-Squad/website-backend#1119
POST /discord-actions/nickname/statusAPI every 6 hours.Warning⚠️