refactor: update timestamp only when no unsuccessful updates #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+53
to
+58
| if (data?.data.unsuccessfulNicknameUpdates === 0) { | ||
| try { | ||
| await namespace.put('DISCORD_NICKNAME_UPDATED_TIME', Date.now().toString()); | ||
| } catch (err) { | ||
| console.error('Error while trying to update the last nickname change timestamp'); | ||
| } |
There was a problem hiding this comment.
Can we also track the failed updates based on Id, and store them it another KV, then try again for the failed ones?
There was a problem hiding this comment.
I think this can be taken up in different issue, while exploring other viable options.
There was a problem hiding this comment.
Then please create the issues and add the link here
There was a problem hiding this comment.
Ajeyakrishna-k
approved these changes
Dec 11, 2023
prakashchoudhary07
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 9th December 2023
Developer Name: @bharati-21
Issue Ticket Number:-
Real-Dev-Squad/website-backend#1755
Description:
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
Add relevant Screenshot below ( e.g test coverage etc. )