-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/local feature flag #240
Feature/local feature flag #240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix below comments
@@ -257,6 +261,18 @@ const AuthScreen = () => { | |||
text={Strings.SIGN_IN_WITH_WEB} | |||
onPress={activateCamera} | |||
/> | |||
<AuthScreenButton | |||
text={ | |||
API_BASE_URL === 'https://api.realdevsquad.com/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we check this in some other file?
src/reducers/featureFlag.reducer.ts
Outdated
@@ -0,0 +1,24 @@ | |||
export const featureFlagState = { | |||
API_BASE_URL: 'https://api.realdevsquad.com/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's move base api url in constant file
src/reducers/featureFlag.reducer.ts
Outdated
case 'STAGING': | ||
return { | ||
...state, | ||
API_BASE_URL: 'https://staging-api.realdevsquad.com/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesnt look good
@mohammadkhizerkhan, should we hide the feature flag or make it less visible to normal users? If so, why give them a button to switch between different environments? We could add gestures or toggle buttons to switch instead. |
yes, i need to discuss this with @shreya-mishra. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can I have the video of switching the feature as well for example if we are in prod then it should show only profile and home screen otherwise it should show all three tabs
Screen.Recording.2023-09-16.at.8.18.39.PM.mov