Feature/local feature flag #240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -257,6 +261,18 @@ const AuthScreen = () => { | |||
| text={Strings.SIGN_IN_WITH_WEB} | |||
| onPress={activateCamera} | |||
| /> | |||
| <AuthScreenButton | |||
| text={ | |||
| API_BASE_URL === 'https://api.realdevsquad.com/' | |||
There was a problem hiding this comment.
can we check this in some other file?
src/reducers/featureFlag.reducer.ts
Outdated
| @@ -0,0 +1,24 @@ | |||
| export const featureFlagState = { | |||
| API_BASE_URL: 'https://api.realdevsquad.com/', | |||
There was a problem hiding this comment.
let's move base api url in constant file
src/reducers/featureFlag.reducer.ts
Outdated
| case 'STAGING': | ||
| return { | ||
| ...state, | ||
| API_BASE_URL: 'https://staging-api.realdevsquad.com/', |
|
@mohammadkhizerkhan, should we hide the feature flag or make it less visible to normal users? If so, why give them a button to switch between different environments? We could add gestures or toggle buttons to switch instead. |
yes, i need to discuss this with @shreya-mishra. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-09-16.at.8.18.39.PM.mov