Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests/navbar #43

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Tests/navbar #43

merged 4 commits into from
Feb 29, 2024

Conversation

satyam73
Copy link
Member

@satyam73 satyam73 commented Feb 25, 2024 •
edited
Loading

Date: 25-02-2024

Developer Name: Satyam Bajpai

Issue Ticket Number

Description

This PR contains tests for the navbar component.

Note: Tests are failing because this PR only contains only test for Navbar component and the actual code for this component is in PR #44 . I will merge this PR to PR #44 . This is being done to split the PRs into multiple small PRs.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

Test Coverage

image

Test Coverage screenshot

Additional Notes

@vercel Vercel
Copy link

vercel bot commented Feb 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skill-tree-frontend-6x4w ❌ Failed (Inspect) Feb 28, 2024 3:30pm

bhtibrewal
bhtibrewal previously approved these changes Feb 25, 2024
View reviewed changes
@satyam73 satyam73 changed the title Tests/navbar [DO-NOT-MERGE] Tests/navbar Feb 25, 2024
@satyam73 satyam73 dismissed bhtibrewal’s stale review February 25, 2024 17:35

The merge-base changed after approval.

@satyam73 satyam73 self-assigned this Feb 27, 2024
@sahsisunny sahsisunny changed the base branch from develop to feat/navbar February 27, 2024 10:32
@sahsisunny sahsisunny changed the base branch from feat/navbar to develop February 27, 2024 10:32
ajoykumardas12
ajoykumardas12 previously approved these changes Feb 28, 2024
View reviewed changes
@satyam73 satyam73 changed the base branch from develop to feat/navbar February 28, 2024 08:29
@satyam73 satyam73 changed the base branch from feat/navbar to develop February 28, 2024 08:30
@satyam73 satyam73 dismissed ajoykumardas12’s stale review February 28, 2024 08:30

The base branch was changed.

@sahsisunny sahsisunny changed the base branch from develop to feat/navbar February 28, 2024 08:39
@sahsisunny sahsisunny changed the base branch from feat/navbar to develop February 28, 2024 08:40
@satyam73 satyam73 changed the base branch from develop to feat/navbar February 28, 2024 15:29
@satyam73 satyam73 changed the title [DO-NOT-MERGE] Tests/navbar Tests/navbar Feb 29, 2024
@satyam73 satyam73 merged commit 5abec12 into feat/navbar Feb 29, 2024
1 of 2 checks passed
@satyam73 satyam73 deleted the tests/navbar branch February 29, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Achintya-Chatterjee Achintya-Chatterjee Achintya-Chatterjee approved these changes

@ajoykumardas12 ajoykumardas12 ajoykumardas12 approved these changes

@VinayakaHegade VinayakaHegade VinayakaHegade approved these changes

@bhtibrewal bhtibrewal bhtibrewal left review comments

Assignees

@satyam73 satyam73

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@satyam73 @bhtibrewal @Achintya-Chatterjee @ajoykumardas12 @VinayakaHegade @sahsisunny