Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: URL redirection issue on redirect page #133

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

sahsisunny
Copy link
Member

@sahsisunny sahsisunny commented Aug 6, 2024

Issue Ticket Number

Description

  • Fix bug for not using redirect endpoint

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Tested in Staging?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Screenshots

image

Test Coverage

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 95.3 82.82 88.54 96.06
fixtures 100 100 100 100
users.ts 100 100 100 100
src/components/App 91.66 100 60 90.9
InputSection.tsx 100 100 100 100
OutputSection.tsx 88.23 100 33.33 87.5 78-93
src/components/Button 100 100 100 100
index.tsx 100 100 100 100
src/components/CreateNew 100 100 100 100
index.tsx 100 100 100 100
src/components/Dashboard 100 80 100 100
NoUrlFound.tsx 100 100 100 100
UrlListItem.tsx 100 75 100 100 96
dashboard-layout.tsx 100 100 100 100
src/components/Footer 100 100 100 100
index.tsx 100 100 100 100
src/components/Layout 100 100 100 100
index.tsx 100 100 100 100
src/components/Loader 50 100 0 100
index.tsx 50 100 0 100
src/components/LoginModal 100 100 100 100
index.tsx 100 100 100 100
src/components/Navbar 90.69 75 70 90
NavbarMenuItems.tsx 100 100 100 100
UserProfileButton.tsx 100 100 100 100
index.tsx 86.66 57.14 57.14 86.2 20,42-43,71
src/components/ProfileIcon 100 100 100 100
ProfileIcon.tsx 100 100 100 100
src/components/QRCodeModal 100 100 100 100
index.tsx 100 100 100 100
src/components/Redirect 100 100 100 100
ErrorPage.tsx 100 100 100 100
LoaderTimer.tsx 100 100 100 100
NotFound.tsx 100 100 100 100
RedirectFooter.tsx 100 100 100 100
src/components/ShimmerEffect 100 100 100 100
DashboardShimmer.tsx 100 100 100 100
OutputSectionShimmer.tsx 100 100 100 100
RedirectShimmer.tsx 100 100 100 100
UserLoginShimmer.tsx 100 100 100 100
src/components/Toast 100 100 100 100
index.tsx 100 100 100 100
src/components/icons 100 100 100 100
redirect.tsx 100 100 100 100
signWithGoogle.tsx 100 100 100 100
src/constants 89.47 100 100 100
constants.ts 83.33 100 100 100
url.ts 92.3 100 100 100
src/hooks 96.42 66.66 90.9 100
useAuthenticated.ts 100 100 100 100
useToast.ts 95.23 0 90 100 10
src/pages 85.71 100 0 83.33
_app.tsx 85.71 100 0 83.33 23
src/pages/[redirect] 86.48 75 66.66 90.62
index.tsx 86.48 75 66.66 90.62 32-33,39
src/pages/app 91.22 68.75 100 90.74
index.tsx 91.22 68.75 100 90.74 48-54
src/pages/dashboard 96.66 83.33 83.33 96.55
index.tsx 96.66 83.33 83.33 96.55 25
src/services 100 0 100 100
api.tsx 100 0 100 100 55
src/utils 100 90 100 100
formatDate.ts 100 88.88 100 100 7
validateUrl.ts 100 100 100 100

@sahsisunny sahsisunny changed the title fix: url redirection FIX: URL redirection issue on redirect page Aug 6, 2024
@sahsisunny sahsisunny self-assigned this Aug 6, 2024
@sahsisunny sahsisunny marked this pull request as ready for review August 8, 2024 01:46
Copy link

@tejaskh3 tejaskh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sahsisunny sahsisunny merged commit f84f348 into develop Aug 12, 2024
1 check passed
@sahsisunny sahsisunny deleted the fix/url-redirection branch August 12, 2024 00:31
@vinit717 vinit717 mentioned this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants