Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login modal in dashboard page #147

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Conversation

vinit717
Copy link
Member

@vinit717 vinit717 commented Sep 15, 2024

Issue Ticket Number

Description

Users now can close the login modal from the dashboard when they are not login

Breaking Changes

  • Yes
  • No

If your feature introduces breaking changes or if something is missing, please mention the related issue tickets.

Development Tested?

  • Yes
  • No

Confirm whether the changes have been tested locally during development.

Tested in Staging?

  • Yes
  • No

Indicate whether the changes have been tested in the staging environment.

Under Feature Flag

  • Yes
  • No

Specify if the changes are currently under a feature flag.

Database Changes

  • Yes
  • No

Indicate whether the changes include modifications to the database.

Screenshots

Before

Flonnect_2024-09-15_0e8a970c-165f-4780-9fad-aef0785571e7.mp4

After

Flonnect_2024-09-15_74fea9d9-7fa4-4a5f-87d2-fa8837e868cd.mp4

Test Coverage

image

Additional Notes

Include any additional notes, considerations, or explanations that might be helpful for reviewers.

@vinit717 vinit717 marked this pull request as draft September 15, 2024 09:06
@vinit717 vinit717 self-assigned this Sep 15, 2024
@vinit717 vinit717 marked this pull request as ready for review September 15, 2024 12:28
@iamitprakash iamitprakash merged commit 2045b29 into develop Sep 15, 2024
1 check passed
@iamitprakash iamitprakash deleted the fix/login-dashboard branch September 15, 2024 12:31
@vinit717 vinit717 mentioned this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix login modal on dashboard page
2 participants