Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/fix: Button component with tests and a few minor fixes #22

Merged
merged 6 commits into from
Oct 5, 2023
Merged

feat/fix: Button component with tests and a few minor fixes #22

merged 6 commits into from
Oct 5, 2023

Conversation

j24m
Copy link
Contributor

@j24m j24m commented Oct 2, 2023 •
edited
Loading

Issue :

Description :

  • Added a new React component called Button.
  • Defined a ButtonProps interface to specify the component's props, including type, className, onClick, and children.
  • The Button component renders a button element with the specified props.

Testing :

  • The Button component has been tested using the React Testing Library and Jest. Two test cases have been added.

  • Before :
    image

  • After :
    image

Working Proof :

  • Dashboard :
    image

  • Login :
    image

@netlify
Copy link

netlify bot commented Oct 2, 2023 •
edited
Loading

✅ Deploy Preview for rdsli ready!

Name Link
🔨 Latest commit 1b60bdb
🔍 Latest deploy log https://app.netlify.com/sites/rdsli/deploys/651e4542a16f450008f31c38
😎 Deploy Preview https://deploy-preview-22--rdsli.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@j24m j24m marked this pull request as ready for review October 3, 2023 09:36
kotesh-arya
kotesh-arya reviewed Oct 3, 2023
View reviewed changes
__tests__/components/Button.test.tsx Outdated Show resolved Hide resolved
__tests__/components/Button.test.tsx Outdated Show resolved Hide resolved
sahsisunny
sahsisunny reviewed Oct 3, 2023
View reviewed changes
src/pages/login/index.js Outdated Show resolved Hide resolved
Pratiyushkumar
Pratiyushkumar reviewed Oct 3, 2023
View reviewed changes
Copy link

@Pratiyushkumar Pratiyushkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, try to verify your changes before pushing your code into PR this will avoid unnecessary changes to your PR. Example - NavBar.tsx
this will also avoid increase in number of lines changed

public/assets/icons/add.tsx Show resolved Hide resolved
public/assets/icons/copy.tsx Show resolved Hide resolved
src/components/Button/index.tsx Show resolved Hide resolved
__tests__/components/Button.test.tsx Outdated Show resolved Hide resolved
@gauravsinhaweb
Copy link
Contributor

If all the above comments get resolved, do tag Sumit for the final review @j24m
https://discord.com/channels/673083527624916993/999504987472277514/1158604540275343360

shubhamsinghbundela
shubhamsinghbundela reviewed Oct 3, 2023
View reviewed changes
Copy link

@shubhamsinghbundela shubhamsinghbundela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for great description
and great work

src/components/Button/index.tsx Outdated Show resolved Hide resolved
@gauravsinhaweb
Copy link
Contributor

Don't merge this PR before merging this

sahsisunny
sahsisunny previously approved these changes Oct 5, 2023
View reviewed changes
vinit717
vinit717 previously approved these changes Oct 5, 2023
View reviewed changes
@j24m j24m dismissed stale reviews from vinit717 and sahsisunny via c1c59ff October 5, 2023 05:06
@sahsisunny sahsisunny merged commit d4d22df into develop Oct 5, 2023
5 checks passed
@sahsisunny sahsisunny deleted the feat/button-component branch October 5, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotesh-arya kotesh-arya kotesh-arya left review comments

@Pratiyushkumar Pratiyushkumar Pratiyushkumar left review comments

@sahsisunny sahsisunny sahsisunny approved these changes

@shubhamsinghbundela shubhamsinghbundela shubhamsinghbundela approved these changes

@vinit717 vinit717 vinit717 approved these changes

Assignees

@j24m j24m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@j24m @gauravsinhaweb @kotesh-arya @sahsisunny @Pratiyushkumar @shubhamsinghbundela @vinit717