-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/fix: Button component with tests and a few minor fixes #22
Conversation
✅ Deploy Preview for rdsli ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, try to verify your changes before pushing your code into PR this will avoid unnecessary changes to your PR. Example - NavBar.tsx
this will also avoid increase in number of lines changed
If all the above comments get resolved, do tag Sumit for the final review @j24m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for great description
and great work
Don't merge this PR before merging this |
Issue :
Description :
Testing :
The Button component has been tested using the React Testing Library and Jest. Two test cases have been added.
Before :
After :
Working Proof :
Dashboard :
Login :