Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration: With backend for sign and signout #34

Merged
merged 6 commits into from
Nov 6, 2023

Conversation

sahsisunny
Copy link
Member

@sahsisunny sahsisunny commented Nov 4, 2023

Description:

This pull request represents a significant milestone in our ongoing development efforts for Tiny-Site-Frontend. We have successfully integrated the Sign-In and Sign-Out APIs, enhancing the user authentication and session management capabilities of our application.

Changes Made:

  1. Sign-In Integration:

    • We have integrated the Sign-In API into the frontend, enabling users to authenticate and access their accounts securely. This includes capturing user credentials, making API requests, and handling authentication tokens.
  2. Sign-Out Integration:

    • The Sign-Out API has been seamlessly integrated into the frontend, allowing users to log out of their sessions. This ensures the security and privacy of user accounts and data.

Test Coverage
image

Demo

0673a561-fc43-4363-865f-250853fe7c5f.mp4

Copy link

netlify bot commented Nov 4, 2023

Deploy Preview for rdsli ready!

Name Link
🔨 Latest commit 0d51621
🔍 Latest deploy log https://app.netlify.com/sites/rdsli/deploys/65482ac144398d0008ed5643
😎 Deploy Preview https://deploy-preview-34--rdsli.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yarn.lock Show resolved Hide resolved
@joyguptaa
Copy link

What if a user has multiple Gmail accounts? Sign in with the Google button should have displayed a list of accounts. Can you verify this, if it is working for multiple accounts or not, and add a screen recording for the same?

public/assets/icons/google.tsx Outdated Show resolved Hide resolved
@sahsisunny
Copy link
Member Author

sahsisunny commented Nov 5, 2023

What if a user has multiple Gmail accounts? Sign in with the Google button should have displayed a list of accounts. Can you verify this, if it is working for multiple accounts or not, and add a screen recording for the same?

I don't have multiple Gmail account and this its work if you have

joyguptaa
joyguptaa previously approved these changes Nov 5, 2023
Copy link

@shubhamsinghbundela shubhamsinghbundela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/components/Navbar/index.tsx Outdated Show resolved Hide resolved
src/constants/url.ts Outdated Show resolved Hide resolved
__tests__/hooks/isAuthenticated.test.tsx Outdated Show resolved Hide resolved
…parate directory for fixtures and change API url
Copy link
Member

@vinit717 vinit717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Add issue ticket

src/hooks/isAuthenticated.ts Show resolved Hide resolved
@sahsisunny sahsisunny linked an issue Nov 6, 2023 that may be closed by this pull request
@sahsisunny sahsisunny merged commit 15a1d23 into develop Nov 6, 2023
5 checks passed
@sahsisunny sahsisunny deleted the integration/with-backend-signin branch November 6, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Sign-in and Signup API to Frontend
4 participants