Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI : removed uncessary buttons and improve UI #35

Merged
merged 7 commits into from
Nov 7, 2023

Conversation

sahsisunny
Copy link
Member

@sahsisunny sahsisunny commented Nov 6, 2023

Description:

This pull request focuses on improving the user interface by simplifying the navigation and removing unnecessary elements from the dashboard page. The changes made in this PR include:

  1. Navbar Update: Removed unnecessary options from the navigation bar to streamline the user experience.

  2. Dashboard Page Cleanup: Removed redundant buttons from the dashboard page, enhancing clarity and reducing clutter.

  3. Config: Changes related to snapshots have been made, such as disabling snapshot generation and removing the snapshot generation test.

Screenshot

Before
image

After
image

Toast
image

Test Cases
image

Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for rdsli ready!

Name Link
🔨 Latest commit 48cff5a
🔍 Latest deploy log https://app.netlify.com/sites/rdsli/deploys/654a4bc24df9ef0008d7b998
😎 Deploy Preview https://deploy-preview-35--rdsli.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vinit717
Copy link
Member

vinit717 commented Nov 7, 2023

please mention test stats for pages/dashboard/index

@sahsisunny sahsisunny linked an issue Nov 7, 2023 that may be closed by this pull request
Copy link
Contributor

@gauravsinhaweb gauravsinhaweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add an interactive copy to clipboard functionality, in the dashboard page
  • Improve Navbar test case stats

src/components/Navbar/index.tsx Show resolved Hide resolved
@sahsisunny
Copy link
Member Author

  • Improve Navbar test case stats

We have 10-11 files that need improvement for testing. Additionally, this PR made no changes to the Navbar line showing uncovered.

@gauravsinhaweb
Copy link
Contributor

  • Improve Navbar test case stats

We have 10-11 files that need improvement for testing. Additionally, this PR made no changes to the Navbar line showing uncovered.

comparing it to previous test results of the navbar, it has differences.

@gauravsinhaweb
Copy link
Contributor

  • Add an interactive copy to clipboard functionality, in the dashboard page
  • Improve Navbar test case stats
  • just make it generic, add green tick on click
  • if not link, disable interaction

@sahsisunny
Copy link
Member Author

  • Improve Navbar test case stats

We have 10-11 files that need improvement for testing. Additionally, this PR made no changes to the Navbar line showing uncovered.

comparing it to previous test results of the navbar, it has differences.

Where? Can you share the stats?

@sahsisunny
Copy link
Member Author

  • Add an interactive copy to clipboard functionality, in the dashboard page
  • Improve Navbar test case stats
  • just make it generic, add green tick on click
  • if not link, disable interaction

Toast is added

@gauravsinhaweb
Copy link
Contributor

  • Improve Navbar test case stats

We have 10-11 files that need improvement for testing. Additionally, this PR made no changes to the Navbar line showing uncovered.

comparing it to previous test results of the navbar, it has differences.

Where? Can you share the stats?

my bad, better if navbar stats could be improved

Copy link
Contributor

@gauravsinhaweb gauravsinhaweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the url should not be generated if there is no link provided by the user, add the tests acoordingly

@sahsisunny
Copy link
Member Author

the url should not be generated if there is no link provided by the user, add the tests acoordingly

Feature is not implemented to generate short URL

gauravsinhaweb
gauravsinhaweb previously approved these changes Nov 7, 2023
@gauravsinhaweb
Copy link
Contributor

the url should not be generated if there is no link provided by the user, add the tests acoordingly

Feature is not implemented to generate short URL

I don't think if it is dependent on feature, if the there is no input length, don't call the link generator fn

@iamitprakash iamitprakash merged commit bf716a9 into develop Nov 7, 2023
5 checks passed
@iamitprakash iamitprakash deleted the fix/dashboard-ui branch November 7, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify User Interface and Remove Unnecessary Elements
4 participants