generated from Real-Dev-Squad/website-template
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: added query param in standup display page #413
Merged
prakashchoudhary07
merged 7 commits into
develop
from
feature/add-query-param-in-standup
Jul 23, 2023
Merged
FEATURE: added query param in standup display page #413
prakashchoudhary07
merged 7 commits into
develop
from
feature/add-query-param-in-standup
Jul 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
bksh05
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MayurLund
approved these changes
Jul 21, 2023
Post screenshots for your change |
Added |
Pratiyushkumar
approved these changes
Jul 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
heyrandhir
approved these changes
Jul 22, 2023
gauravsinhaweb
approved these changes
Jul 22, 2023
Ajeyakrishna-k
suggested changes
Jul 23, 2023
Ajeyakrishna-k
approved these changes
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes : #410
What is the change?
__tests__/standup/standup.test.js
: Added test cases for the standup page.standup/script.js
: Added feature to add query parameters to the standup page, allowing the display of a user's standup.Test Code
*Dev Tested?
After Change Screenshots
Note for Reviewer: In the PR I fix the style of the tooltip and sidebar