Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: added query param in standup display page #413

Merged
merged 7 commits into from
Jul 23, 2023

Conversation

sahsisunny
Copy link
Member

@sahsisunny sahsisunny commented Jul 19, 2023

Closes : #410

What is the change?

  1. __tests__/standup/standup.test.js: Added test cases for the standup page.
  2. standup/script.js: Added feature to add query parameters to the standup page, allowing the display of a user's standup.

Test Code

image

*Dev Tested?

  • Yes
  • No

After Change Screenshots

image

Note for Reviewer: In the PR I fix the style of the tooltip and sidebar

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 19, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 806f725
Status: ✅  Deploy successful!
Preview URL: https://bd02e610.dashboard-rds.pages.dev
Branch Preview URL: https://fix-duplication-test-in-stan.dashboard-rds.pages.dev

View logs

Copy link
Contributor

@bksh05 bksh05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sahsisunny sahsisunny marked this pull request as draft July 21, 2023 01:46
@sahsisunny sahsisunny marked this pull request as ready for review July 21, 2023 15:02
@TanishqSingla
Copy link
Contributor

Post screenshots for your change

@sahsisunny
Copy link
Member Author

Post screenshots for your change

Added

Copy link
Contributor

@Pratiyushkumar Pratiyushkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

standup/script.js Show resolved Hide resolved
__tests__/standup/standup.test.js Show resolved Hide resolved
@sahsisunny sahsisunny removed the request for review from iamitprakash July 23, 2023 09:25
@prakashchoudhary07 prakashchoudhary07 merged commit b899a72 into develop Jul 23, 2023
5 checks passed
@prakashchoudhary07 prakashchoudhary07 deleted the feature/add-query-param-in-standup branch July 23, 2023 12:08
@sahsisunny sahsisunny mentioned this pull request Jul 23, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add query parameter for user search in standup page
9 participants