Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/group selection UI tweaks #418

Merged

Conversation

mohibkay
Copy link
Contributor

This PR has Discord groups selection UI tweaks #411

Added:

  • Repositioned the add role button towards top-left
  • Hover effect while hovering over the group list item and mouse pointer

Before:
Screenshot 2023-07-21 at 7 07 51 PM

After:
Screenshot 2023-07-21 at 7 07 56 PM

Copy link
Contributor

@kotesh-arya kotesh-arya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me

Copy link

@ravikumar1002 ravikumar1002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@shubhamsinghbundela shubhamsinghbundela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @mohibkay.
This is design related...ask to ankush also before get merged about the add role button which you shifted top-left
i.e. its look good or not(take his opinion)

@mohibkay
Copy link
Contributor Author

Hey @shubhamsigdar1, thank you for your review.
@ankushdharkar had assigned this issue to me and the design was given by him only.

Could you please merge it?

@shubhamsinghbundela
Copy link

Hey @shubhamsigdar1, thank you for your review.
@ankushdharkar had assigned this issue to me and the design was given by him only.

Could you please merge it?

Reach out to @RitikJaiswal75 @prakashchoudhary07 @ankushdharkar

@ankushdharkar ankushdharkar merged commit b13c77d into Real-Dev-Squad:develop Jul 31, 2023
4 checks passed
@mohibkay mohibkay mentioned this pull request Aug 2, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants