Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: overdue tasks #419

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

feat: overdue tasks #419

wants to merge 11 commits into from

Conversation

ivinayakg
Copy link
Contributor

@ivinayakg ivinayakg commented Jul 22, 2023

Overdue tasks feature

  • Check all the overdue tasks
  • Create extension request for an overdue task
  • unassign user of their task
2023-08-22.00-01-59.mp4

RFC - #300

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 23, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9735f52
Status: ✅  Deploy successful!
Preview URL: https://e686a622.dashboard-rds.pages.dev
Branch Preview URL: https://feat-overdue-tasks-admin.dashboard-rds.pages.dev

View logs

Copy link
Contributor

@Pratiyushkumar Pratiyushkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put your feature behind feature flag
Also I will request you to show the output of the feature, how to do reviewer know the things you are doing in your feature returns successful output

.vscode/settings.json Outdated Show resolved Hide resolved
overdue-tasks/style.css Show resolved Hide resolved
overdue-tasks/style.css Show resolved Hide resolved
script.js Show resolved Hide resolved
style.css Show resolved Hide resolved
@ivinayakg
Copy link
Contributor Author

Please put your feature behind feature flag Also I will request you to show the output of the feature, how to do reviewer know the things you are doing in your feature returns successful output

I Have added the video above only, is it not enough?
@Pratiyushkumar

@Pratiyushkumar
Copy link
Contributor

Please put your feature behind feature flag Also I will request you to show the output of the feature, how to do reviewer know the things you are doing in your feature returns successful output

I Have added the video above only, is it not enough? @Pratiyushkumar

I am not able to see the ouptu

Please put your feature behind feature flag Also I will request you to show the output of the feature, how to do reviewer know the things you are doing in your feature returns successful output

I Have added the video above only, is it not enough? @Pratiyushkumar

After unassigning the task to the user how can I know if the task has been unassigned or not...

NIT - if I click on the unassign button then only the modal should open and we should be able to all the working functionality, I don't think we should have two buttons for it one for unassigning and another for creating an extension request.

@Pratiyushkumar
Copy link
Contributor

Please put your feature behind feature flag Also I will request you to show the output of the feature, how to do reviewer know the things you are doing in your feature returns successful output

I Have added the video above only, is it not enough? @Pratiyushkumar

Also put your feature behind feature flag please

Copy link
Contributor

@Pratiyushkumar Pratiyushkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please divide your PR into parts, initially it's very long for me to review and also please include tests and coverage without r them I wont be able to review your PR

@Pratiyushkumar Pratiyushkumar self-requested a review October 1, 2023 11:35
@Pratiyushkumar Pratiyushkumar dismissed their stale review October 1, 2023 11:40

dismissing self review as this task is re-assigned to me

@Pratiyushkumar Pratiyushkumar removed their request for review October 1, 2023 11:40
@Pratiyushkumar Pratiyushkumar self-assigned this Oct 1, 2023
@Pratiyushkumar Pratiyushkumar self-requested a review October 1, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants