Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Update query params on the browser url #437

Merged
merged 13 commits into from
Aug 9, 2023

Conversation

j24m
Copy link
Contributor

@j24m j24m commented Jul 31, 2023

Description :

  • Implemented a mechanism to update the URL parameters when filters are applied, reflecting the filtered state on browser URL.
  • Persisting user data & filters based on query parameters.
  • Handling case sensitivity for query parameter values.
  • Persisting the filters and user data when the url(along with the query params) is shared with other people or opened on a new tab.
  • Clearing the query params when clicked on clear filters button.

Video with changes :

20230807-234708_1yu8AKzb.mp4

@j24m j24m self-assigned this Jul 31, 2023
@j24m j24m marked this pull request as ready for review August 6, 2023 18:29
users/script.js Outdated Show resolved Hide resolved
users/script.js Outdated Show resolved Hide resolved
@RitikJaiswal75 RitikJaiswal75 changed the base branch from develop to dependabot/npm_and_yarn/node-fetch-and-puppeteer-and-puppeteer-core-2.6.7 August 7, 2023 16:27
@RitikJaiswal75 RitikJaiswal75 changed the base branch from dependabot/npm_and_yarn/node-fetch-and-puppeteer-and-puppeteer-core-2.6.7 to develop August 7, 2023 16:28
iamitprakash
iamitprakash previously approved these changes Aug 7, 2023
users/script.js Outdated Show resolved Hide resolved
users/script.js Outdated Show resolved Hide resolved
users/script.js Outdated Show resolved Hide resolved
@iamitprakash iamitprakash merged commit 76d7f77 into Real-Dev-Squad:develop Aug 9, 2023
4 checks passed
@j24m j24m mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants