Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add user profile with dropdown after sign in through github #535

Merged

Conversation

khemchand-twt11
Copy link
Contributor

@khemchand-twt11 khemchand-twt11 commented Oct 1, 2023

Fix : After the user signs in through GitHub, the PR enables the user to access their profile with various options using dropdown.

Fixes #530

Before:
Description: After sign in with github there is no user profile on the home page.

before.mp4

After:
Description: If the user has logged in he/she will be able to see user profile with dropdown options.

task1.mp4

Test Cases
Alltestcasepassing

@khemchand-twt11 khemchand-twt11 marked this pull request as ready for review October 3, 2023 11:23
script.js Outdated Show resolved Hide resolved
script.js Outdated Show resolved Hide resolved
script.js Outdated Show resolved Hide resolved
style.css Outdated Show resolved Hide resolved
utils.js Show resolved Hide resolved
utils.js Show resolved Hide resolved
Copy link
Member

@sahsisunny sahsisunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write the tests for the changes and add test stats in the description.

Copy link

@shubhamsinghbundela shubhamsinghbundela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the test??

@khemchand-twt11
Copy link
Contributor Author

Where is the test??

Didn't know about writing tests.

Copy link
Member

@Achintya-Chatterjee Achintya-Chatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solve the merge conflicts

sahsisunny
sahsisunny previously approved these changes Oct 9, 2023
script.js Outdated Show resolved Hide resolved
script.js Show resolved Hide resolved
@iamitprakash iamitprakash merged commit 3fc6a7a into Real-Dev-Squad:develop Oct 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile Icon and Name Not Displayed After GitHub Sign-In
6 participants